chrome/browser/extensions/extension_context_menu_model.h - Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_context_menu_model.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Compile fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_api.h ('k') | chrome/browser/extensions/extension_context_menu_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_context_menu_model.h

diff --git a/chrome/browser/extensions/extension_context_menu_model.h b/chrome/browser/extensions/extension_context_menu_model.h

index 0d9e833dabff06101597bcc03c2c2464e6e0d0ba..9144a5f379fb87f9227285a004ad8fc24aa0ca0f 100644

--- a/chrome/browser/extensions/extension_context_menu_model.h

+++ b/chrome/browser/extensions/extension_context_menu_model.h

@@ -26,7 +26,6 @@ class ExtensionContextMenuModel

public:

// Creates a menu model for the given extension action.

ExtensionContextMenuModel(const Extension* extension, Browser* browser);

- virtual ~ExtensionContextMenuModel();

// SimpleMenuModel::Delegate overrides.

virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;

@@ -41,6 +40,9 @@ class ExtensionContextMenuModel

virtual void ExtensionUninstallCanceled() OVERRIDE;

private:

+ friend class base::RefCounted<ExtensionContextMenuModel>;

+ virtual ~ExtensionContextMenuModel();

void InitCommonCommands();

// Gets the extension we are displaying the menu for. Returns NULL if the