Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: chrome/browser/extensions/extension_input_ime_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_input_ime_api.h
diff --git a/chrome/browser/extensions/extension_input_ime_api.h b/chrome/browser/extensions/extension_input_ime_api.h
index c8e0d33c4383df711d9f382640d5e7400aa275e5..02b01682f9a1cacb45f189a22019cee679f224f6 100644
--- a/chrome/browser/extensions/extension_input_ime_api.h
+++ b/chrome/browser/extensions/extension_input_ime_api.h
@@ -67,37 +67,58 @@ class ExtensionInputImeEventRouter {
class SetCompositionFunction : public SyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("input.ime.setComposition");
+
+ protected:
virtual ~SetCompositionFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("input.ime.setComposition");
};
class ClearCompositionFunction : public SyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("input.ime.clearComposition");
+
+ protected:
virtual ~ClearCompositionFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("input.ime.clearComposition");
};
class CommitTextFunction : public SyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("input.ime.commitText");
+
+ protected:
virtual ~CommitTextFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("input.ime.commitText");
};
class SetCandidateWindowPropertiesFunction : public SyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("input.ime.setCandidateWindowProperties");
+
+ protected:
virtual ~SetCandidateWindowPropertiesFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("input.ime.setCandidateWindowProperties");
};
class SetCandidatesFunction : public SyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("input.ime.setCandidates");
+
+ protected:
virtual ~SetCandidatesFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("input.ime.setCandidates");
+
private:
bool ReadCandidates(
ListValue* candidates,
@@ -106,30 +127,46 @@ class SetCandidatesFunction : public SyncExtensionFunction {
class SetCursorPositionFunction : public SyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("input.ime.setCursorPosition");
+
+ protected:
virtual ~SetCursorPositionFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("input.ime.setCursorPosition");
};
class SetMenuItemsFunction : public SyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("input.ime.setMenuItems");
+
+ protected:
virtual ~SetMenuItemsFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("input.ime.setMenuItems");
};
class UpdateMenuItemsFunction : public SyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("input.ime.updateMenuItems");
+
+ protected:
virtual ~UpdateMenuItemsFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("input.ime.updateMenuItems");
};
class InputEventHandled : public AsyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("input.ime.eventHandled");
+
+ protected:
virtual ~InputEventHandled() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("input.ime.eventHandled");
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_INPUT_IME_API_H_
« no previous file with comments | « chrome/browser/extensions/extension_input_api.h ('k') | chrome/browser/extensions/extension_input_ime_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698