Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4226)

Unified Diff: chrome/browser/extensions/extension_info_map.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_info_map.h ('k') | chrome/browser/extensions/extension_input_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_info_map.cc
diff --git a/chrome/browser/extensions/extension_info_map.cc b/chrome/browser/extensions/extension_info_map.cc
index 82492d9920d5bc0e02cee5699d61397ebc7256eb..8db94d504e50af4549f3a1e28feef63c330896d6 100644
--- a/chrome/browser/extensions/extension_info_map.cc
+++ b/chrome/browser/extensions/extension_info_map.cc
@@ -19,7 +19,6 @@ void CheckOnValidThread() {
} // namespace
-
struct ExtensionInfoMap::ExtraData {
// When the extension was installed.
base::Time install_time;
@@ -31,22 +30,11 @@ struct ExtensionInfoMap::ExtraData {
~ExtraData();
};
-ExtensionInfoMap::ExtraData::ExtraData() : incognito_enabled(false) {
-}
+ExtensionInfoMap::ExtraData::ExtraData() : incognito_enabled(false) {}
-ExtensionInfoMap::ExtraData::~ExtraData() {
-}
+ExtensionInfoMap::ExtraData::~ExtraData() {}
-
-ExtensionInfoMap::ExtensionInfoMap() {
-}
-
-ExtensionInfoMap::~ExtensionInfoMap() {
- if (quota_service_.get()) {
- BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE,
- quota_service_.release());
- }
-}
+ExtensionInfoMap::ExtensionInfoMap() {}
const extensions::ProcessMap& ExtensionInfoMap::process_map() const {
return process_map_;
@@ -159,3 +147,10 @@ ExtensionsQuotaService* ExtensionInfoMap::GetQuotaService() {
quota_service_.reset(new ExtensionsQuotaService());
return quota_service_.get();
}
+
+ExtensionInfoMap::~ExtensionInfoMap() {
+ if (quota_service_.get()) {
+ BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE,
+ quota_service_.release());
+ }
+}
« no previous file with comments | « chrome/browser/extensions/extension_info_map.h ('k') | chrome/browser/extensions/extension_input_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698