Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: chrome/browser/extensions/settings/settings_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings/settings_api.h
diff --git a/chrome/browser/extensions/settings/settings_api.h b/chrome/browser/extensions/settings/settings_api.h
index 1728e9f550f84236dacdb3494360342bbe2264b3..eb9dfe14fdba83b9a87e86834e7ce694daf8fac3 100644
--- a/chrome/browser/extensions/settings/settings_api.h
+++ b/chrome/browser/extensions/settings/settings_api.h
@@ -22,11 +22,11 @@ namespace extensions {
// TODO(kalman): Rename these functions, and all files under
// chrome/browser/extensions/settings.
class SettingsFunction : public AsyncExtensionFunction {
- public:
+ protected:
SettingsFunction();
virtual ~SettingsFunction();
- protected:
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
// Extension settings function implementations should do their work here.
@@ -63,6 +63,9 @@ class GetSettingsFunction : public SettingsFunction {
DECLARE_EXTENSION_FUNCTION_NAME("storage.get");
protected:
+ virtual ~GetSettingsFunction() {}
+
+ // SettingsFunction:
virtual bool RunWithStorage(SettingsStorage* storage) OVERRIDE;
};
@@ -71,8 +74,12 @@ class SetSettingsFunction : public SettingsFunction {
DECLARE_EXTENSION_FUNCTION_NAME("storage.set");
protected:
+ virtual ~SetSettingsFunction() {}
+
+ // SettingsFunction:
virtual bool RunWithStorage(SettingsStorage* storage) OVERRIDE;
+ // ExtensionFunction:
virtual void GetQuotaLimitHeuristics(
QuotaLimitHeuristics* heuristics) const OVERRIDE;
};
@@ -82,8 +89,12 @@ class RemoveSettingsFunction : public SettingsFunction {
DECLARE_EXTENSION_FUNCTION_NAME("storage.remove");
protected:
+ virtual ~RemoveSettingsFunction() {}
+
+ // SettingsFunction:
virtual bool RunWithStorage(SettingsStorage* storage) OVERRIDE;
+ // ExtensionFunction:
virtual void GetQuotaLimitHeuristics(
QuotaLimitHeuristics* heuristics) const OVERRIDE;
};
@@ -93,8 +104,12 @@ class ClearSettingsFunction : public SettingsFunction {
DECLARE_EXTENSION_FUNCTION_NAME("storage.clear");
protected:
+ virtual ~ClearSettingsFunction() {}
+
+ // SettingsFunction:
virtual bool RunWithStorage(SettingsStorage* storage) OVERRIDE;
+ // ExtensionFunction:
virtual void GetQuotaLimitHeuristics(
QuotaLimitHeuristics* heuristics) const OVERRIDE;
};
@@ -104,6 +119,9 @@ class GetBytesInUseSettingsFunction : public SettingsFunction {
DECLARE_EXTENSION_FUNCTION_NAME("storage.getBytesInUse");
protected:
+ virtual ~GetBytesInUseSettingsFunction() {}
+
+ // SettingsFunction:
virtual bool RunWithStorage(SettingsStorage* storage) OVERRIDE;
};
« no previous file with comments | « chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc ('k') | chrome/browser/extensions/system/system_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698