chrome/browser/extensions/api/declarative/rules_registry_with_cache.h - Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Compile fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/initializing_rules_registry.cc ('k') | chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache.h

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache.h b/chrome/browser/extensions/api/declarative/rules_registry_with_cache.h

index 82f6aec7139657d1127c313adfe2efae8f17f0ad..4ad4e510c83eceb55657d8b970d70e7e07e544bb 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache.h

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache.h

@@ -20,7 +20,6 @@ namespace extensions {

class RulesRegistryWithCache : public RulesRegistry {

public:

RulesRegistryWithCache();

- virtual ~RulesRegistryWithCache();

// RulesRegistry implementation:

virtual std::string AddRules(

@@ -42,6 +41,8 @@ class RulesRegistryWithCache : public RulesRegistry {

virtual content::BrowserThread::ID GetOwnerThread() const = 0;

protected:

+ virtual ~RulesRegistryWithCache();

// These functions need to provide the same functionality as their

// RulesRegistry counterparts. They need to be atomic.

virtual std::string AddRulesImpl(