Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2261)

Unified Diff: chrome/browser/extensions/extension_content_settings_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_content_settings_api.h
diff --git a/chrome/browser/extensions/extension_content_settings_api.h b/chrome/browser/extensions/extension_content_settings_api.h
index 5a9ecb2f55439c9bda50f7707dd6b95715498211..c8e4eb60e714c3802ac86ba3c0c4532b001c48a7 100644
--- a/chrome/browser/extensions/extension_content_settings_api.h
+++ b/chrome/browser/extensions/extension_content_settings_api.h
@@ -16,27 +16,47 @@ class PluginGroup;
class ClearContentSettingsFunction : public SyncExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("contentSettings.clear")
+
+ protected:
+ virtual ~ClearContentSettingsFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class GetContentSettingFunction : public SyncExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("contentSettings.get")
+
+ protected:
+ virtual ~GetContentSettingFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class SetContentSettingFunction : public SyncExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("contentSettings.set")
+
+ protected:
+ virtual ~SetContentSettingFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class GetResourceIdentifiersFunction : public AsyncExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("contentSettings.getResourceIdentifiers")
+ protected:
+ virtual ~GetResourceIdentifiersFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
+
private:
FRIEND_TEST_ALL_PREFIXES(ExtensionApiTest,
ContentSettingsGetResourceIdentifiers);
« no previous file with comments | « chrome/browser/extensions/extension_chrome_auth_private_api.h ('k') | chrome/browser/extensions/extension_context_menu_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698