Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: chrome/browser/extensions/api/declarative/declarative_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative/declarative_api.h
diff --git a/chrome/browser/extensions/api/declarative/declarative_api.h b/chrome/browser/extensions/api/declarative/declarative_api.h
index fc198449e666a2860ff1bfed1e282a7bd764e34b..609302688c259278256ed00769ef39f52c0c7f87 100644
--- a/chrome/browser/extensions/api/declarative/declarative_api.h
+++ b/chrome/browser/extensions/api/declarative/declarative_api.h
@@ -16,7 +16,11 @@ namespace extensions {
class RulesFunction : public AsyncExtensionFunction {
public:
RulesFunction();
+
+ protected:
virtual ~RulesFunction();
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
// Concrete implementation of the RulesFunction that is being called
@@ -24,26 +28,40 @@ class RulesFunction : public AsyncExtensionFunction {
// Returns false in case of errors.
virtual bool RunImplOnCorrectThread() = 0;
- protected:
scoped_refptr<RulesRegistry> rules_registry_;
};
class AddRulesFunction : public RulesFunction {
public:
- virtual bool RunImplOnCorrectThread() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("experimental.declarative.addRules");
+
+ protected:
+ virtual ~AddRulesFunction() {}
+
+ // RulesFunction:
+ virtual bool RunImplOnCorrectThread() OVERRIDE;
};
class RemoveRulesFunction : public RulesFunction {
public:
- virtual bool RunImplOnCorrectThread() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("experimental.declarative.removeRules");
+
+ protected:
+ virtual ~RemoveRulesFunction() {}
+
+ // RulesFunction:
+ virtual bool RunImplOnCorrectThread() OVERRIDE;
};
class GetRulesFunction : public RulesFunction {
public:
- virtual bool RunImplOnCorrectThread() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("experimental.declarative.getRules");
+
+ protected:
+ virtual ~GetRulesFunction() {}
+
+ // RulesFunction:
+ virtual bool RunImplOnCorrectThread() OVERRIDE;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698