[sql] Import reference version of SQLite 3.17..

[sql] Import reference version of SQLite 3.17..

Import the source for 3.17 per README.chromium.  This does not modify
the build in any way, it is being landed before being enabled to keep
the landing review focussed.

BUG=701518
TBR=cmumford@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2747283002 .
Cr-Commit-Position: refs/heads/master@{#457160}
Committed: https://chromium.googlesource.com/chromium/src/+/2691beb8121e400ae6893ff9b119c08f687c33a1

[Scott Hess - ex-Googler, 2017-03-14 23:13:17]

Chris, I picked you because of random reasons.  You sit in the same meetings as
me, and Michael maybe deserves some time off from this.

TBR because this is not connected to the build, so anything which goes wrong
isn't likely to be flushed by code review.

NOPRESUBMIT=true because it fails a presumit on use of TARGET_OS_EMBEDDED.

NOTRY=true because binary files.

And, looking at https://codereview.chromium.org/1610543003 , I expect to have to
land it manually anyhow.

[Scott Hess - ex-Googler, 2017-03-14 23:15:23]

On 2017/03/14 23:13:17, Scott Hess wrote:
> Chris, I picked you because of random reasons.  You sit in the same meetings
as
> me, and Michael maybe deserves some time off from this.
> 
> TBR because this is not connected to the build, so anything which goes wrong
> isn't likely to be flushed by code review.

Um, yes, this implies that there will be another review to impact the build.  It
will also be gigantic, so I'll list out the bits needing attention.

Then a third removing the old import, another rubber-stamp.

And others as needed, but AFAICT the import so far looks pretty clean, so I'm
hopeful that that won't happen.

[Scott Hess - ex-Googler, 2017-03-14 23:15:58]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2017-03-14 23:17:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 23:19:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 23:19:42]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

This could be a Rietveld flake (see http://crbug.com/401833), so if this CL has
no binary files, please re-check commit box.
Thanks for your patience.

Transient error: Can't process patch for file
third_party/sqlite/sqlite-src-3170000/test/fuzzdata1.db.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

[Scott Hess - ex-Googler, 2017-03-14 23:22:41]

On 2017/03/14 23:19:42, commit-bot: I haz the power wrote:
> Failed to request the patch to try. Please note that binary files are still
> unsupported at the moment, this is being worked on.
> 
> This could be a Rietveld flake (see http://crbug.com/401833), so if this CL
has
> no binary files, please re-check commit box.
> Thanks for your patience.
> 
> Transient error: Can't process patch for file
> third_party/sqlite/sqlite-src-3170000/test/fuzzdata1.db.
> Binary file is empty. Maybe the file wasn't uploaded in the first place?

Well, there you go, manual landing it is.

I'm going to give you a couple hours to veto this, because I don't remember
manual landing offhand, and I'm tired of this CL series.

[Scott Hess - ex-Googler, 2017-03-15 19:16:00]

Description was changed from

==========
[sql] Import reference version of SQLite 3.17..

Import the source for 3.17 per README.chromium.  This does not modify
the build in any way, it is being landed before being enabled to keep
the landing review focussed.

BUG=701518
TBR=cmumford@chromium.org
NOPRESUBMIT=true
NOTRY=true
==========

to

==========
[sql] Import reference version of SQLite 3.17..

Import the source for 3.17 per README.chromium.  This does not modify
the build in any way, it is being landed before being enabled to keep
the landing review focussed.

BUG=701518
TBR=cmumford@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2747283002 .
Cr-Commit-Position: refs/heads/master@{#457160}
Committed:
https://chromium.googlesource.com/chromium/src/+/2691beb8121e400ae6893ff9b119...
==========

[Scott Hess - ex-Googler, 2017-03-15 19:16:10]

Committed patchset #1 (id:1) manually as
2691beb8121e400ae6893ff9b119c08f687c33a1.