base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

BUG=581865
R=thakis@chromium.org
TBR=jochen@chromium.org,junov@chromium.org,rdevlin.cronin@chromium.org,rogerta@chromium.org,sky@chromium.org,xhwang@chromium.org,wez@chromium.org,zea@chromium.org

Committed: https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408
Cr-Commit-Position: refs/heads/master@{#398941}

[dcheng, 2016-06-09 03:59:19]

dcheng@chromium.org changed reviewers:
+ jam@chromium.org

[dcheng, 2016-06-09 03:59:21]

+jam, mind taking a look? Pretty straightforward cleanup generated by running
https://codereview.chromium.org/2056573002 on a Chromium build. Headers were
inserted using the scripts in https://codereview.chromium.org/1505823003.

[jam, 2016-06-09 15:56:13]

On 2016/06/09 03:59:21, dcheng wrote:
> +jam, mind taking a look? Pretty straightforward cleanup generated by running
> https://codereview.chromium.org/2056573002 on a Chromium build. Headers were
> inserted using the scripts in https://codereview.chromium.org/1505823003.

top level owners aren't really for these kind of changes. please see
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...,
i.e. if you have approval from api (i.e. in base/), you can tbr owners in the
consumers' directories.

[dcheng, 2016-06-09 16:12:38]

dcheng@chromium.org changed reviewers:
+ thakis@chromium.org

[dcheng, 2016-06-09 16:12:39]

+thakis, mind reviewing this one?

[Nico, 2016-06-09 16:57:35]

nice, lgtm

One tangentially related question:

https://codereview.chromium.org/2051663003/diff/40001/extensions/browser/api/...
File extensions/browser/api/declarative/rules_registry.cc (right):

https://codereview.chromium.org/2051663003/diff/40001/extensions/browser/api/...
extensions/browser/api/declarative/rules_registry.cc:46: return std::move(list);
huh, why doesn't clang issue a -Wpessimizing-move here?

[dcheng, 2016-06-09 17:09:46]

https://codereview.chromium.org/2051663003/diff/40001/extensions/browser/api/...
File extensions/browser/api/declarative/rules_registry.cc (right):

https://codereview.chromium.org/2051663003/diff/40001/extensions/browser/api/...
extensions/browser/api/declarative/rules_registry.cc:46: return std::move(list);
On 2016/06/09 16:57:35, Nico wrote:
> huh, why doesn't clang issue a -Wpessimizing-move here?

C++11 still requires an explicit std::move() here, since it's converting from
unique_ptr<ListValue> to unique_ptr<Value>. With C++14, I think that will no
longer be the case (though I think it's still a move under the hood).

[dcheng, 2016-06-09 17:20:50]

Description was changed from

==========
base::ListValue::Append cleanup: pass unique_ptr instead of the released
pointer.

BUG=581865
==========

to

==========
base::ListValue::Append cleanup: pass unique_ptr instead of the released
pointer.

BUG=581865
==========

[dcheng, 2016-06-09 17:20:50]

dcheng@chromium.org changed reviewers:
+ jochen@chromium.org, junov@chromium.org, rdevlin.cronin@chromium.org,
rogerta@chromium.org, sky@chromium.org, wez@chromium.org, xhwang@chromium.org,
zea@chromium.org

[dcheng, 2016-06-09 17:22:07]

Description was changed from

==========
base::ListValue::Append cleanup: pass unique_ptr instead of the released
pointer.

BUG=581865
==========

to

==========
base::ListValue::Append cleanup: pass unique_ptr instead of the released
pointer.

BUG=581865
R=thakis@chromium.org
TBR=jochen@chromium.org,junov@chromium.org,rdevlin.cronin@chromium.org,rogert...
==========

[dcheng, 2016-06-09 17:22:23]

Mass TBRing owners of top-level directories.

[dcheng, 2016-06-09 17:22:38]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-06-09 17:23:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051663003/40001

[Devlin, 2016-06-09 17:40:03]

mass lgtming extensions, json_schema_compiler

[Devlin, 2016-06-09 17:40:26]

On 2016/06/09 17:40:03, Devlin wrote:
> mass lgtming extensions, json_schema_compiler

grr lgtm ing

[commit-bot: I haz the power, 2016-06-09 17:53:53]

Description was changed from

==========
base::ListValue::Append cleanup: pass unique_ptr instead of the released
pointer.

BUG=581865
R=thakis@chromium.org
TBR=jochen@chromium.org,junov@chromium.org,rdevlin.cronin@chromium.org,rogert...
==========

to

==========
base::ListValue::Append cleanup: pass unique_ptr instead of the released
pointer.

BUG=581865
R=thakis@chromium.org
TBR=jochen@chromium.org,junov@chromium.org,rdevlin.cronin@chromium.org,rogert...
==========

[commit-bot: I haz the power, 2016-06-09 17:53:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-09 17:54:16]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-09 17:59:57]

Description was changed from

==========
base::ListValue::Append cleanup: pass unique_ptr instead of the released
pointer.

BUG=581865
R=thakis@chromium.org
TBR=jochen@chromium.org,junov@chromium.org,rdevlin.cronin@chromium.org,rogert...
==========

to

==========
base::ListValue::Append cleanup: pass unique_ptr instead of the released
pointer.

BUG=581865
R=thakis@chromium.org
TBR=jochen@chromium.org,junov@chromium.org,rdevlin.cronin@chromium.org,rogert...

Committed: https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408
Cr-Commit-Position: refs/heads/master@{#398941}
==========

[commit-bot: I haz the power, 2016-06-09 18:00:00]

Patchset 3 (id:??) landed as
https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408
Cr-Commit-Position: refs/heads/master@{#398941}

[Wez, 2016-06-09 19:39:43]

remoting/ LGTM

On 9 June 2016 at 10:59, commit-bot@chromium.org via codereview.chromium.org
<reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 3 (id:??) landed as
> https://crrev.com/5d09049ddefb1e992be88f3137a54362e9ea5408
> Cr-Commit-Position: refs/heads/master@{#398941}
>
> https://codereview.chromium.org/2051663003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Wez, 2016-06-09 19:43:11]

lgtm