base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

chrome/browser/extensions/api/copresence/copresence_api_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/copresence/copresence_api.h"
 
 #include <utility>
 
 #include "base/json/json_writer.h"
 #include "base/memory/ptr_util.h"
@@ skipping 113 matching lines @@
     function->set_extension(extension());
     function->set_browser_context(profile());
     function->set_has_callback(true);
     test_utils::RunFunction(function.get(), std::move(args_list), browser(),
                             test_utils::NONE);
     return function->GetResultList();
   }
 
   bool ExecuteOperation(std::unique_ptr<Operation> operation) {
     ListValue* operation_list = new ListValue;
-    operation_list->Append(operation->ToValue().release());
+    operation_list->Append(operation->ToValue());
     return ExecuteOperations(operation_list);
   }
 
   const ReportRequest& request_sent() const {
     return copresence_manager_->request_;
   }
 
   const std::string& app_id_sent() const {
     return copresence_manager_->app_id_;
   }
@@ skipping 64 matching lines @@
 }
 
 TEST_F(CopresenceApiUnittest, DefaultStrategies) {
   std::unique_ptr<Operation> publish_operation(new Operation);
   publish_operation->publish.reset(CreatePublish("pub"));
 
   std::unique_ptr<Operation> subscribe_operation(new Operation);
   subscribe_operation->subscribe.reset(CreateSubscribe("sub"));
 
   ListValue* operation_list = new ListValue;
-  operation_list->Append(publish_operation->ToValue().release());
-  operation_list->Append(subscribe_operation->ToValue().release());
+  operation_list->Append(publish_operation->ToValue());
+  operation_list->Append(subscribe_operation->ToValue());
   EXPECT_TRUE(ExecuteOperations(operation_list));
 
   EXPECT_EQ(BROADCAST_ONLY,
             request_sent().manage_messages_request().message_to_publish(0)
                 .token_exchange_strategy().broadcast_scan_configuration());
   EXPECT_EQ(SCAN_ONLY,
             request_sent().manage_subscriptions_request().subscription(0)
                 .token_exchange_strategy().broadcast_scan_configuration());
 }
 
 TEST_F(CopresenceApiUnittest, LowPowerStrategy) {
   std::unique_ptr<Operation> subscribe_operation(new Operation);
   subscribe_operation->subscribe.reset(CreateSubscribe("sub"));
   subscribe_operation->subscribe->strategies.reset(new Strategy);
   subscribe_operation->subscribe->strategies->low_power.reset(new bool(true));
 
   ListValue* operation_list = new ListValue;
-  operation_list->Append(subscribe_operation->ToValue().release());
+  operation_list->Append(subscribe_operation->ToValue());
   EXPECT_TRUE(ExecuteOperations(operation_list));
 
   EXPECT_EQ(copresence::BROADCAST_SCAN_CONFIGURATION_UNKNOWN,
             request_sent().manage_subscriptions_request().subscription(0)
                 .token_exchange_strategy().broadcast_scan_configuration());
 }
 
 TEST_F(CopresenceApiUnittest, UnPubSub) {
   // First we need to create a publish and a subscribe to cancel.
   std::unique_ptr<Operation> publish_operation(new Operation);
   std::unique_ptr<Operation> subscribe_operation(new Operation);
   publish_operation->publish.reset(CreatePublish("pub"));
   subscribe_operation->subscribe.reset(CreateSubscribe("sub"));
   ListValue* operation_list = new ListValue;
-  operation_list->Append(publish_operation->ToValue().release());
-  operation_list->Append(subscribe_operation->ToValue().release());
+  operation_list->Append(publish_operation->ToValue());
+  operation_list->Append(subscribe_operation->ToValue());
   EXPECT_TRUE(ExecuteOperations(operation_list));
 
   std::unique_ptr<Operation> unpublish_operation(new Operation);
   unpublish_operation->unpublish.reset(new UnpublishOperation);
   unpublish_operation->unpublish->unpublish_id = "pub";
 
   std::unique_ptr<Operation> unsubscribe_operation(new Operation);
   unsubscribe_operation->unsubscribe.reset(new UnsubscribeOperation);
   unsubscribe_operation->unsubscribe->unsubscribe_id = "sub";
 
   operation_list = new ListValue;
-  operation_list->Append(unpublish_operation->ToValue().release());
-  operation_list->Append(unsubscribe_operation->ToValue().release());
+  operation_list->Append(unpublish_operation->ToValue());
+  operation_list->Append(unsubscribe_operation->ToValue());
   EXPECT_TRUE(ExecuteOperations(operation_list));
 
   std::string unpublish_id;
   ASSERT_TRUE(GetOnly(
       request_sent().manage_messages_request().id_to_unpublish(),
       &unpublish_id));
   EXPECT_EQ("pub", unpublish_id);
 
   std::string unsubscribe_id;
   ASSERT_TRUE(GetOnly(
@@ skipping 14 matching lines @@
   std::unique_ptr<Operation> multi_operation(new Operation);
   multi_operation->publish.reset(CreatePublish("pub"));
   multi_operation->subscribe.reset(CreateSubscribe("sub"));
 
   EXPECT_FALSE(ExecuteOperation(std::move(multi_operation)));
 }
 
 }  // namespace extensions
 
 // TODO(ckehoe): add tests for auth tokens and api key functionality