Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: chrome/browser/extensions/permissions_updater.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/permissions_updater.cc
diff --git a/chrome/browser/extensions/permissions_updater.cc b/chrome/browser/extensions/permissions_updater.cc
index 4370e3214939ed9d3565d61660a7015d0721bd6e..26730a999aaa4510a01500c6c3bab92db4b18f12 100644
--- a/chrome/browser/extensions/permissions_updater.cc
+++ b/chrome/browser/extensions/permissions_updater.cc
@@ -232,7 +232,7 @@ void PermissionsUpdater::DispatchEvent(
std::unique_ptr<base::ListValue> value(new base::ListValue());
std::unique_ptr<api::permissions::Permissions> permissions =
PackPermissionSet(changed_permissions);
- value->Append(permissions->ToValue().release());
+ value->Append(permissions->ToValue());
std::unique_ptr<Event> event(
new Event(histogram_value, event_name, std::move(value)));
event->restrict_to_browser_context = browser_context_;

Powered by Google App Engine
This is Rietveld 408576698