Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1807)

Side by Side Diff: extensions/browser/api/storage/settings_test_util.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/storage/settings_test_util.h" 5 #include "extensions/browser/api/storage/settings_test_util.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "extensions/browser/api/storage/storage_frontend.h" 8 #include "extensions/browser/api/storage/storage_frontend.h"
9 #include "extensions/browser/extension_registry.h" 9 #include "extensions/browser/extension_registry.h"
10 #include "extensions/browser/extension_system_provider.h" 10 #include "extensions/browser/extension_system_provider.h"
(...skipping 11 matching lines...) Expand all
22 for (int i = 0; i < 1024; ++i) { 22 for (int i = 0; i < 1024; ++i) {
23 kilobyte_string += "a"; 23 kilobyte_string += "a";
24 } 24 }
25 return std::unique_ptr<base::Value>(new base::StringValue(kilobyte_string)); 25 return std::unique_ptr<base::Value>(new base::StringValue(kilobyte_string));
26 } 26 }
27 27
28 // Creates a megabyte of data. 28 // Creates a megabyte of data.
29 std::unique_ptr<base::Value> CreateMegabyte() { 29 std::unique_ptr<base::Value> CreateMegabyte() {
30 base::ListValue* megabyte = new base::ListValue(); 30 base::ListValue* megabyte = new base::ListValue();
31 for (int i = 0; i < 1000; ++i) { 31 for (int i = 0; i < 1000; ++i) {
32 megabyte->Append(CreateKilobyte().release()); 32 megabyte->Append(CreateKilobyte());
33 } 33 }
34 return std::unique_ptr<base::Value>(megabyte); 34 return std::unique_ptr<base::Value>(megabyte);
35 } 35 }
36 36
37 // Intended as a StorageCallback from GetStorage. 37 // Intended as a StorageCallback from GetStorage.
38 static void AssignStorage(ValueStore** dst, ValueStore* src) { 38 static void AssignStorage(ValueStore** dst, ValueStore* src) {
39 *dst = src; 39 *dst = src;
40 } 40 }
41 41
42 ValueStore* GetStorage(scoped_refptr<const Extension> extension, 42 ValueStore* GetStorage(scoped_refptr<const Extension> extension,
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 it != permissions_set.end(); ++it) { 114 it != permissions_set.end(); ++it) {
115 DCHECK(extension->permissions_data()->HasAPIPermission(*it)); 115 DCHECK(extension->permissions_data()->HasAPIPermission(*it));
116 } 116 }
117 117
118 return extension; 118 return extension;
119 } 119 }
120 120
121 } // namespace settings_test_util 121 } // namespace settings_test_util
122 122
123 } // namespace extensions 123 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698