Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: components/signin/core/browser/about_signin_internals.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/about_signin_internals.cc
diff --git a/components/signin/core/browser/about_signin_internals.cc b/components/signin/core/browser/about_signin_internals.cc
index 5d2c4b8ad69fd8c55ed1e54ac5bee089623ddf8d..ec1595333f61bebd0c7f2e8aa3c648669c3bf053 100644
--- a/components/signin/core/browser/about_signin_internals.cc
+++ b/components/signin/core/browser/about_signin_internals.cc
@@ -6,6 +6,8 @@
#include <stddef.h>
+#include <utility>
+
#include "base/command_line.h"
#include "base/hash.h"
#include "base/i18n/time_formatting.h"
@@ -42,7 +44,7 @@ base::ListValue* AddSection(base::ListValue* parent_list,
section->SetString("title", title);
section->Set("data", section_contents);
- parent_list->Append(section.release());
+ parent_list->Append(std::move(section));
return section_contents;
}
@@ -54,7 +56,7 @@ void AddSectionEntry(base::ListValue* section_list,
entry->SetString("label", field_name);
entry->SetString("status", field_status);
entry->SetString("time", field_time);
- section_list->Append(entry.release());
+ section_list->Append(std::move(entry));
}
void AddCookieEntry(base::ListValue* accounts_list,
@@ -65,7 +67,7 @@ void AddCookieEntry(base::ListValue* accounts_list,
entry->SetString("email", field_email);
entry->SetString("gaia_id", field_gaia_id);
entry->SetString("valid", field_valid);
- accounts_list->Append(entry.release());
+ accounts_list->Append(std::move(entry));
}
std::string SigninStatusFieldToLabel(UntimedSigninStatusField field) {

Powered by Google App Engine
This is Rietveld 408576698