Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: remoting/protocol/protocol_mock_objects.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/protocol_mock_objects.cc
diff --git a/remoting/protocol/protocol_mock_objects.cc b/remoting/protocol/protocol_mock_objects.cc
index 69b1b5c3e20917a564301f1d6fe907d0bc345f50..3450cf919b419615074183526c7439c0bfd29683 100644
--- a/remoting/protocol/protocol_mock_objects.cc
+++ b/remoting/protocol/protocol_mock_objects.cc
@@ -59,7 +59,7 @@ std::unique_ptr<base::ListValue> MockPairingRegistryDelegate::LoadAll() {
std::unique_ptr<base::ListValue> result(new base::ListValue());
for (Pairings::const_iterator i = pairings_.begin(); i != pairings_.end();
++i) {
- result->Append(i->second.ToValue().release());
+ result->Append(i->second.ToValue());
}
return result;
}

Powered by Google App Engine
This is Rietveld 408576698