Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/guest_view/extensions_guest_view_manager_delegate.h " 5 #include "extensions/browser/guest_view/extensions_guest_view_manager_delegate.h "
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "components/guest_view/browser/guest_view_base.h" 9 #include "components/guest_view/browser/guest_view_base.h"
10 #include "components/guest_view/browser/guest_view_manager.h" 10 #include "components/guest_view/browser/guest_view_manager.h"
(...skipping 27 matching lines...) Expand all
38 } 38 }
39 39
40 void ExtensionsGuestViewManagerDelegate::DispatchEvent( 40 void ExtensionsGuestViewManagerDelegate::DispatchEvent(
41 const std::string& event_name, 41 const std::string& event_name,
42 std::unique_ptr<base::DictionaryValue> args, 42 std::unique_ptr<base::DictionaryValue> args,
43 GuestViewBase* guest, 43 GuestViewBase* guest,
44 int instance_id) { 44 int instance_id) {
45 EventFilteringInfo info; 45 EventFilteringInfo info;
46 info.SetInstanceID(instance_id); 46 info.SetInstanceID(instance_id);
47 std::unique_ptr<base::ListValue> event_args(new base::ListValue()); 47 std::unique_ptr<base::ListValue> event_args(new base::ListValue());
48 event_args->Append(args.release()); 48 event_args->Append(std::move(args));
49 49
50 // GetEventHistogramValue maps guest view event names to their histogram 50 // GetEventHistogramValue maps guest view event names to their histogram
51 // value. It needs to be like this because the guest view component doesn't 51 // value. It needs to be like this because the guest view component doesn't
52 // know about extensions, so GuestViewEvent can't have an 52 // know about extensions, so GuestViewEvent can't have an
53 // extensions::events::HistogramValue as an argument. 53 // extensions::events::HistogramValue as an argument.
54 events::HistogramValue histogram_value = 54 events::HistogramValue histogram_value =
55 guest_view_events::GetEventHistogramValue(event_name); 55 guest_view_events::GetEventHistogramValue(event_name);
56 DCHECK_NE(events::UNKNOWN, histogram_value) << "Event " << event_name 56 DCHECK_NE(events::UNKNOWN, histogram_value) << "Event " << event_name
57 << " must have a histogram value"; 57 << " must have a histogram value";
58 58
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 void ExtensionsGuestViewManagerDelegate::RegisterAdditionalGuestViewTypes() { 96 void ExtensionsGuestViewManagerDelegate::RegisterAdditionalGuestViewTypes() {
97 GuestViewManager* manager = GuestViewManager::FromBrowserContext(context_); 97 GuestViewManager* manager = GuestViewManager::FromBrowserContext(context_);
98 manager->RegisterGuestViewType<AppViewGuest>(); 98 manager->RegisterGuestViewType<AppViewGuest>();
99 manager->RegisterGuestViewType<ExtensionOptionsGuest>(); 99 manager->RegisterGuestViewType<ExtensionOptionsGuest>();
100 manager->RegisterGuestViewType<ExtensionViewGuest>(); 100 manager->RegisterGuestViewType<ExtensionViewGuest>();
101 manager->RegisterGuestViewType<MimeHandlerViewGuest>(); 101 manager->RegisterGuestViewType<MimeHandlerViewGuest>();
102 manager->RegisterGuestViewType<WebViewGuest>(); 102 manager->RegisterGuestViewType<WebViewGuest>();
103 } 103 }
104 104
105 } // namespace extensions 105 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698