extensions/browser/api/bluetooth/bluetooth_api.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/bluetooth/bluetooth_api.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/app_runtime/app_runtime_api.cc ('k') | extensions/browser/api/declarative/rules_registry.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/bluetooth/bluetooth_api.cc

diff --git a/extensions/browser/api/bluetooth/bluetooth_api.cc b/extensions/browser/api/bluetooth/bluetooth_api.cc

index 6d0b00304af1248747dda41140935b030e3fc237..3580c88813f29705b2883bd768e872eafcc9be1b 100644

--- a/extensions/browser/api/bluetooth/bluetooth_api.cc

+++ b/extensions/browser/api/bluetooth/bluetooth_api.cc

@@ -129,7 +129,7 @@ bool BluetoothGetDevicesFunction::DoWork(

bluetooth::Device extension_device;

bluetooth::BluetoothDeviceToApiDevice(*device, &extension_device);

- device_list->Append(extension_device.ToValue().release());

+ device_list->Append(extension_device.ToValue());

}

SetResult(std::move(device_list));