components/dom_distiller/webui/dom_distiller_handler.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/webui/dom_distiller_handler.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browser_sync/browser/profile_sync_service.cc ('k') | components/domain_reliability/context_manager.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/webui/dom_distiller_handler.cc

diff --git a/components/dom_distiller/webui/dom_distiller_handler.cc b/components/dom_distiller/webui/dom_distiller_handler.cc

index e0c090686df72890f462a0094cd657265b4e2003..9d8970b6631ffd9df3511220d2662ef5a25a25f4 100644

--- a/components/dom_distiller/webui/dom_distiller_handler.cc

+++ b/components/dom_distiller/webui/dom_distiller_handler.cc

@@ -4,6 +4,7 @@

#include "components/dom_distiller/webui/dom_distiller_handler.h"

+#include <utility>

#include <vector>

#include "base/bind.h"

@@ -114,7 +115,7 @@ void DomDistillerHandler::HandleRequestEntries(const base::ListValue* args) {

? article.entry_id()

: article.title();

entry->SetString("title", net::EscapeForHTML(title));

- entries.Append(entry.release());

+ entries.Append(std::move(entry));

}

// TODO(nyquist): Write a test that ensures we sanitize the data we send.

web_ui()->CallJavascriptFunctionUnsafe("domDistiller.onReceivedEntries",