Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: tools/json_schema_compiler/test/idl_schemas_unittest.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/idl_schemas_unittest.cc
diff --git a/tools/json_schema_compiler/test/idl_schemas_unittest.cc b/tools/json_schema_compiler/test/idl_schemas_unittest.cc
index d0c13346f837ffe95c474186296178d44f86a200..e010346926074c9ca5b4fa4698f01da3bb4b1c73 100644
--- a/tools/json_schema_compiler/test/idl_schemas_unittest.cc
+++ b/tools/json_schema_compiler/test/idl_schemas_unittest.cc
@@ -2,12 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <utility>
+
#include "base/values.h"
+#include "testing/gtest/include/gtest/gtest.h"
#include "tools/json_schema_compiler/test/idl_basics.h"
#include "tools/json_schema_compiler/test/idl_object_types.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
using test::api::idl_basics::MyType1;
using test::api::idl_object_types::BarType;
using test::api::idl_object_types::FooType;
@@ -157,8 +158,8 @@ TEST(IdlCompiler, ArrayTypes) {
a.y = std::string("foo");
b.y = std::string("bar");
base::ListValue* sublist2 = new base::ListValue;
- sublist2->Append(a.ToValue().release());
- sublist2->Append(b.ToValue().release());
+ sublist2->Append(a.ToValue());
+ sublist2->Append(b.ToValue());
list.Append(sublist2);
std::unique_ptr<Function11::Params> f11_params =
Function11::Params::Create(list);
@@ -197,7 +198,7 @@ TEST(IdlCompiler, ObjectTypes) {
EXPECT_TRUE(ObjectFunction1::Params::Icon::Populate(*(icon_props.get()),
&icon));
base::ListValue list;
- list.Append(icon_props.release());
+ list.Append(std::move(icon_props));
std::unique_ptr<ObjectFunction1::Params> params =
ObjectFunction1::Params::Create(list);
ASSERT_TRUE(params.get() != NULL);

Powered by Google App Engine
This is Rietveld 408576698