base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

chrome/browser/metrics/plugin_metrics_provider_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/plugin_metrics_provider.h"
 
 #include <stddef.h>
 
 #include <string>
+#include <utility>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/pref_names.h"
 #include "components/metrics/proto/system_profile.pb.h"
 #include "components/prefs/pref_service.h"
 #include "components/prefs/scoped_user_pref_update.h"
 #include "components/prefs/testing_pref_service.h"
 #include "content/public/browser/child_process_data.h"
@@ skipping 69 matching lines @@
 
   // Now set some plugin stability stats for p2 and verify they're recorded.
   std::unique_ptr<base::DictionaryValue> plugin_dict(new base::DictionaryValue);
   plugin_dict->SetString(prefs::kStabilityPluginName, "p2");
   plugin_dict->SetInteger(prefs::kStabilityPluginLaunches, 1);
   plugin_dict->SetInteger(prefs::kStabilityPluginCrashes, 2);
   plugin_dict->SetInteger(prefs::kStabilityPluginInstances, 3);
   plugin_dict->SetInteger(prefs::kStabilityPluginLoadingErrors, 4);
   {
     ListPrefUpdate update(prefs(), prefs::kStabilityPluginStats);
-    update.Get()->Append(plugin_dict.release());
+    update.Get()->Append(std::move(plugin_dict));
   }
 
   provider.ProvideStabilityMetrics(&system_profile);
 
   const metrics::SystemProfileProto_Stability& stability =
       system_profile.stability();
   ASSERT_EQ(1, stability.plugin_stability_size());
   EXPECT_EQ("p2", stability.plugin_stability(0).plugin().name());
   EXPECT_EQ("p2.plugin", stability.plugin_stability(0).plugin().filename());
   EXPECT_EQ("2.0", stability.plugin_stability(0).plugin().version());
@@ skipping 93 matching lines @@
     } else if (name == "p2") {
       EXPECT_EQ(2, stability.plugin_stability(i).launch_count());
       EXPECT_EQ(2, stability.plugin_stability(i).crash_count());
       found++;
     } else {
       GTEST_FAIL() << "Unexpected plugin name : " << name;
     }
   }
   EXPECT_EQ(found, 2U);
 }