base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

media/cdm/json_web_key.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cdm/json_web_key.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 55 matching lines @@
   jwk->SetString(kKeyIdTag, key_id_string);
   return jwk;
 }
 
 std::string GenerateJWKSet(const uint8_t* key,
                            int key_length,
                            const uint8_t* key_id,
                            int key_id_length) {
   // Create the JWK, and wrap it into a JWK Set.
   std::unique_ptr<base::ListValue> list(new base::ListValue());
-  list->Append(
-      CreateJSONDictionary(key, key_length, key_id, key_id_length).release());
+  list->Append(CreateJSONDictionary(key, key_length, key_id, key_id_length));
   base::DictionaryValue jwk_set;
   jwk_set.Set(kKeysTag, list.release());
 
   // Finally serialize |jwk_set| into a string and return it.
   std::string serialized_jwk;
   JSONStringValueSerializer serializer(&serialized_jwk);
   serializer.Serialize(jwk_set);
   return serialized_jwk;
 }
 
 std::string GenerateJWKSet(const KeyIdAndKeyPairs& keys,
                            MediaKeys::SessionType session_type) {
   std::unique_ptr<base::ListValue> list(new base::ListValue());
   for (const auto& key_pair : keys) {
     list->Append(CreateJSONDictionary(
-                     reinterpret_cast<const uint8_t*>(key_pair.second.data()),
-                     key_pair.second.length(),
-                     reinterpret_cast<const uint8_t*>(key_pair.first.data()),
-                     key_pair.first.length())
-                     .release());
+        reinterpret_cast<const uint8_t*>(key_pair.second.data()),
+        key_pair.second.length(),
+        reinterpret_cast<const uint8_t*>(key_pair.first.data()),
+        key_pair.first.length()));
   }
 
   base::DictionaryValue jwk_set;
   jwk_set.Set(kKeysTag, list.release());
   switch (session_type) {
     case MediaKeys::TEMPORARY_SESSION:
       jwk_set.SetString(kTypeTag, kTemporarySession);
       break;
     case MediaKeys::PERSISTENT_LICENSE_SESSION:
       jwk_set.SetString(kTypeTag, kPersistentLicenseSession);
@@ skipping 303 matching lines @@
     DVLOG(1) << "Invalid '" << kKeyIdsTag << "' value: " << encoded_key;
     return false;
   }
 
   std::vector<uint8_t> result(decoded_string.begin(), decoded_string.end());
   first_key->swap(result);
   return true;
 }
 
 }  // namespace media