chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/copresence/copresence_api_unittest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc b/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

index e43e598970ff03b17bcc5dfb32203586345e34de..8f881fe7c4b22c8343a5d1f1a1c307e871996647 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

@@ -406,7 +406,7 @@ TEST_F(DeveloperPrivateApiUnitTest, DeveloperPrivateLoadUnpacked) {

base::ListValue unpacked_args;

std::unique_ptr<base::DictionaryValue> options(new base::DictionaryValue());

options->SetBoolean("failQuietly", true);

- unpacked_args.Append(options.release());

+ unpacked_args.Append(std::move(options));

current_ids = registry()->enabled_extensions().GetIDs();

EXPECT_FALSE(RunFunction(function, unpacked_args));

EXPECT_EQ(manifest_errors::kManifestUnreadable, function->GetError());

@@ -432,7 +432,7 @@ TEST_F(DeveloperPrivateApiUnitTest, DeveloperPrivateRequestFileSource) {

scoped_refptr<UIThreadExtensionFunction> function(

new api::DeveloperPrivateRequestFileSourceFunction());

base::ListValue file_source_args;

- file_source_args.Append(properties.ToValue().release());

+ file_source_args.Append(properties.ToValue());

EXPECT_TRUE(RunFunction(function, file_source_args)) << function->GetError();

const base::Value* response_value = nullptr;