Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: ui/events/latency_info.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/latency_info.cc
diff --git a/ui/events/latency_info.cc b/ui/events/latency_info.cc
index a2bc9782170af79c039b86f5fb4c142bf30a807e..8a5ac1b6afeae10bf42f4d257f7aa34fa1f37587 100644
--- a/ui/events/latency_info.cc
+++ b/ui/events/latency_info.cc
@@ -339,7 +339,7 @@ LatencyInfo::CoordinatesAsTraceableData() {
new base::DictionaryValue());
coordinate_pair->SetDouble("x", input_coordinates_[i].x());
coordinate_pair->SetDouble("y", input_coordinates_[i].y());
- coordinates->Append(coordinate_pair.release());
+ coordinates->Append(std::move(coordinate_pair));
}
return LatencyInfoTracedValue::FromValue(std::move(coordinates));
}

Powered by Google App Engine
This is Rietveld 408576698