Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: tools/json_schema_compiler/test/arrays_unittest.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/arrays_unittest.cc
diff --git a/tools/json_schema_compiler/test/arrays_unittest.cc b/tools/json_schema_compiler/test/arrays_unittest.cc
index f43d1d329120354108c06497e9fa0b4a49ce8bc3..5d68563710ed1c58ef5fbfc8c26c42591e71d7aa 100644
--- a/tools/json_schema_compiler/test/arrays_unittest.cc
+++ b/tools/json_schema_compiler/test/arrays_unittest.cc
@@ -7,6 +7,7 @@
#include <stddef.h>
#include <memory>
+#include <utility>
#include "base/macros.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -186,7 +187,7 @@ TEST(JsonSchemaCompilerArrayTest, IntegerArrayParamsCreate) {
integer_array->AppendInteger(2);
integer_array->AppendInteger(4);
integer_array->AppendInteger(8);
- params_value->Append(integer_array.release());
+ params_value->Append(std::move(integer_array));
std::unique_ptr<IntegerArray::Params> params(
IntegerArray::Params::Create(*params_value));
EXPECT_TRUE(params.get());
@@ -202,7 +203,7 @@ TEST(JsonSchemaCompilerArrayTest, AnyArrayParamsCreate) {
any_array->AppendInteger(1);
any_array->AppendString("test");
any_array->Append(CreateItemValue(2));
- params_value->Append(any_array.release());
+ params_value->Append(std::move(any_array));
std::unique_ptr<AnyArray::Params> params(
AnyArray::Params::Create(*params_value));
EXPECT_TRUE(params.get());
@@ -217,7 +218,7 @@ TEST(JsonSchemaCompilerArrayTest, ObjectArrayParamsCreate) {
std::unique_ptr<base::ListValue> item_array(new base::ListValue());
item_array->Append(CreateItemValue(1));
item_array->Append(CreateItemValue(2));
- params_value->Append(item_array.release());
+ params_value->Append(std::move(item_array));
std::unique_ptr<ObjectArray::Params> params(
ObjectArray::Params::Create(*params_value));
EXPECT_TRUE(params.get());
@@ -231,7 +232,7 @@ TEST(JsonSchemaCompilerArrayTest, RefArrayParamsCreate) {
std::unique_ptr<base::ListValue> item_array(new base::ListValue());
item_array->Append(CreateItemValue(1));
item_array->Append(CreateItemValue(2));
- params_value->Append(item_array.release());
+ params_value->Append(std::move(item_array));
std::unique_ptr<RefArray::Params> params(
RefArray::Params::Create(*params_value));
EXPECT_TRUE(params.get());

Powered by Google App Engine
This is Rietveld 408576698