Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2115)

Unified Diff: chrome/browser/metrics/plugin_metrics_provider_unittest.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/plugin_metrics_provider_unittest.cc
diff --git a/chrome/browser/metrics/plugin_metrics_provider_unittest.cc b/chrome/browser/metrics/plugin_metrics_provider_unittest.cc
index 0bc4f2341b149fcb05d04b1960eceaa82c681099..3582351ddd61c5235cfc6d6bbdf506cc1f44c3f0 100644
--- a/chrome/browser/metrics/plugin_metrics_provider_unittest.cc
+++ b/chrome/browser/metrics/plugin_metrics_provider_unittest.cc
@@ -7,6 +7,7 @@
#include <stddef.h>
#include <string>
+#include <utility>
#include "base/macros.h"
#include "base/run_loop.h"
@@ -96,7 +97,7 @@ TEST_F(PluginMetricsProviderTest, Plugins) {
plugin_dict->SetInteger(prefs::kStabilityPluginLoadingErrors, 4);
{
ListPrefUpdate update(prefs(), prefs::kStabilityPluginStats);
- update.Get()->Append(plugin_dict.release());
+ update.Get()->Append(std::move(plugin_dict));
}
provider.ProvideStabilityMetrics(&system_profile);

Powered by Google App Engine
This is Rietveld 408576698