extensions/browser/api/alarms/alarm_manager.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/alarms/alarm_manager.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/devtools/v8_sampling_profiler_browsertest.cc ('k') | extensions/browser/api/app_runtime/app_runtime_api.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/alarms/alarm_manager.cc

diff --git a/extensions/browser/api/alarms/alarm_manager.cc b/extensions/browser/api/alarms/alarm_manager.cc

index b382dff81f05133c22097c4d749053cf796c50f0..7325906fbe0a6cc2d8e2ded7e7f2d05e101ae25f 100644

--- a/extensions/browser/api/alarms/alarm_manager.cc

+++ b/extensions/browser/api/alarms/alarm_manager.cc

@@ -46,7 +46,7 @@ class DefaultAlarmDelegate : public AlarmManager::Delegate {

void OnAlarm(const std::string& extension_id, const Alarm& alarm) override {

std::unique_ptr<base::ListValue> args(new base::ListValue());

- args->Append(alarm.js_alarm->ToValue().release());

+ args->Append(alarm.js_alarm->ToValue());

std::unique_ptr<Event> event(new Event(

events::ALARMS_ON_ALARM, alarms::OnAlarm::kEventName, std::move(args)));

EventRouter::Get(browser_context_)

@@ -87,7 +87,7 @@ std::unique_ptr<base::ListValue> AlarmsToValue(

alarms[i].js_alarm->ToValue();

alarm->Set(kAlarmGranularity,

base::CreateTimeDeltaValue(alarms[i].granularity));

- list->Append(alarm.release());

+ list->Append(std::move(alarm));

}

return list;

}