extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/declarative/rules_registry.cc ('K') | « extensions/browser/event_listener_map_unittest.cc ('k') | extensions/common/event_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

diff --git a/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc b/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

index 8c73d37391da5e247d7113eaa0385b1f68c448bc..49461b052b5bd3469f3896def332d3c3846c5e59 100644

--- a/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

+++ b/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

@@ -45,7 +45,7 @@ void ExtensionsGuestViewManagerDelegate::DispatchEvent(

EventFilteringInfo info;

info.SetInstanceID(instance_id);

std::unique_ptr<base::ListValue> event_args(new base::ListValue());

- event_args->Append(args.release());

+ event_args->Append(std::move(args));

// GetEventHistogramValue maps guest view event names to their histogram

// value. It needs to be like this because the guest view component doesn't