chrome/test/chromedriver/chrome/log.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/log.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc ('k') | chrome/test/chromedriver/commands.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/log.cc

diff --git a/chrome/test/chromedriver/chrome/log.cc b/chrome/test/chromedriver/chrome/log.cc

index 99a1ac3f307bd5ee52827d578424fc8f3b83603e..c98ab48dfa5aa35e3453048fd74d0f5940e3d740 100644

--- a/chrome/test/chromedriver/chrome/log.cc

+++ b/chrome/test/chromedriver/chrome/log.cc

@@ -67,7 +67,7 @@ std::unique_ptr<base::Value> SmartDeepCopy(const base::Value* value) {

list_copy->AppendString("...");

break;

}

- list_copy->Append(SmartDeepCopy(child).release());

+ list_copy->Append(SmartDeepCopy(child));

}

return std::move(list_copy);

} else if (value->GetAsString(&data)) {