components/domain_reliability/scheduler.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/domain_reliability/scheduler.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/domain_reliability/context_manager.cc ('k') | components/drive/service/fake_drive_service.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/domain_reliability/scheduler.cc

diff --git a/components/domain_reliability/scheduler.cc b/components/domain_reliability/scheduler.cc

index de9df5ebd450a5bb20fe10ba702af8a9a12d3242..6e0aa6b3d96f299ed7be988aab1fe828110e9dc5 100644

--- a/components/domain_reliability/scheduler.cc

+++ b/components/domain_reliability/scheduler.cc

@@ -190,7 +190,7 @@ std::unique_ptr<base::Value> DomainReliabilityScheduler::GetWebUIData() const {

value->SetInteger("next_upload",

(collector->GetReleaseTime() - now).InSeconds());

// Using release instead of Pass because Pass can't implicitly upcast.

- collectors_value->Append(value.release());

+ collectors_value->Append(std::move(value));

}

data->Set("collectors", std::move(collectors_value));