chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/invalidations_message_handler.cc ('k') | chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

diff --git a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

index 6f61b65528ed733420e95b0884ae005b1230c492..6c7e2fc9cbef9536a728bc459df60425f0105ab7 100644

--- a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

+++ b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

@@ -80,13 +80,13 @@ void ReadDevicesList(const CloudPrintPrinterList::DeviceList& devices,

base::ListValue* devices_list) {

for (const auto& i : devices) {

if (ContainsKey(local_ids, i.id)) {

- devices_list->Append(CreateDeviceInfo(i).release());

+ devices_list->Append(CreateDeviceInfo(i));

}

for (const auto& i : devices) {

if (!ContainsKey(local_ids, i.id)) {

- devices_list->Append(CreateDeviceInfo(i).release());

+ devices_list->Append(CreateDeviceInfo(i));

}