Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1808)

Unified Diff: chrome/browser/extensions/api/copresence/copresence_api_unittest.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/copresence/copresence_api_unittest.cc
diff --git a/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc b/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc
index 298047243fe869d52f1129a8cf7bee1aea05bacc..eacfe7a6fc53502ab0acbe7b37c3b6caaf9bb3ff 100644
--- a/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc
+++ b/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc
@@ -131,7 +131,7 @@ class CopresenceApiUnittest : public ExtensionApiUnittest {
bool ExecuteOperation(std::unique_ptr<Operation> operation) {
ListValue* operation_list = new ListValue;
- operation_list->Append(operation->ToValue().release());
+ operation_list->Append(operation->ToValue());
return ExecuteOperations(operation_list);
}
@@ -216,8 +216,8 @@ TEST_F(CopresenceApiUnittest, DefaultStrategies) {
subscribe_operation->subscribe.reset(CreateSubscribe("sub"));
ListValue* operation_list = new ListValue;
- operation_list->Append(publish_operation->ToValue().release());
- operation_list->Append(subscribe_operation->ToValue().release());
+ operation_list->Append(publish_operation->ToValue());
+ operation_list->Append(subscribe_operation->ToValue());
EXPECT_TRUE(ExecuteOperations(operation_list));
EXPECT_EQ(BROADCAST_ONLY,
@@ -235,7 +235,7 @@ TEST_F(CopresenceApiUnittest, LowPowerStrategy) {
subscribe_operation->subscribe->strategies->low_power.reset(new bool(true));
ListValue* operation_list = new ListValue;
- operation_list->Append(subscribe_operation->ToValue().release());
+ operation_list->Append(subscribe_operation->ToValue());
EXPECT_TRUE(ExecuteOperations(operation_list));
EXPECT_EQ(copresence::BROADCAST_SCAN_CONFIGURATION_UNKNOWN,
@@ -250,8 +250,8 @@ TEST_F(CopresenceApiUnittest, UnPubSub) {
publish_operation->publish.reset(CreatePublish("pub"));
subscribe_operation->subscribe.reset(CreateSubscribe("sub"));
ListValue* operation_list = new ListValue;
- operation_list->Append(publish_operation->ToValue().release());
- operation_list->Append(subscribe_operation->ToValue().release());
+ operation_list->Append(publish_operation->ToValue());
+ operation_list->Append(subscribe_operation->ToValue());
EXPECT_TRUE(ExecuteOperations(operation_list));
std::unique_ptr<Operation> unpublish_operation(new Operation);
@@ -263,8 +263,8 @@ TEST_F(CopresenceApiUnittest, UnPubSub) {
unsubscribe_operation->unsubscribe->unsubscribe_id = "sub";
operation_list = new ListValue;
- operation_list->Append(unpublish_operation->ToValue().release());
- operation_list->Append(unsubscribe_operation->ToValue().release());
+ operation_list->Append(unpublish_operation->ToValue());
+ operation_list->Append(unsubscribe_operation->ToValue());
EXPECT_TRUE(ExecuteOperations(operation_list));
std::string unpublish_id;

Powered by Google App Engine
This is Rietveld 408576698