chrome/test/chromedriver/logging.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/logging.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/element_util.cc ('k') | components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/logging.cc

diff --git a/chrome/test/chromedriver/logging.cc b/chrome/test/chromedriver/logging.cc

index 7f891ac24e21366642d4fa8e20556dff276896d3..67f60e4acff040e479f71ccc41daaa2c4ebed961 100644

--- a/chrome/test/chromedriver/logging.cc

+++ b/chrome/test/chromedriver/logging.cc

@@ -8,6 +8,8 @@

#include <stdint.h>

#include <stdio.h>

+#include <utility>

#include "base/command_line.h"

#include "base/json/json_reader.h"

#include "base/logging.h"

@@ -188,7 +190,7 @@ void WebDriverLog::AddEntryTimestamped(const base::Time& timestamp,

if (!source.empty())

log_entry_dict->SetString("source", source);

log_entry_dict->SetString("message", message);

- entries_->Append(log_entry_dict.release());

+ entries_->Append(std::move(log_entry_dict));

}

const std::string& WebDriverLog::type() const {