extensions/common/permissions/set_disjunction_permission.h - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/set_disjunction_permission.h

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/declarative/rules_registry.cc ('K') | « extensions/common/event_filter_unittest.cc ('k') | extensions/renderer/dom_activity_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/set_disjunction_permission.h

diff --git a/extensions/common/permissions/set_disjunction_permission.h b/extensions/common/permissions/set_disjunction_permission.h

index fedcf2c8aeab53bfc04fb7e54a19b453061a6526..eaf614d8f497551b4d9ab097639892160121a447 100644

--- a/extensions/common/permissions/set_disjunction_permission.h

+++ b/extensions/common/permissions/set_disjunction_permission.h

@@ -10,6 +10,7 @@

#include <memory>

#include <set>

#include <string>

+#include <utility>

#include "base/json/json_writer.h"

#include "base/values.h"

@@ -147,7 +148,7 @@ class SetDisjunctionPermission : public APIPermission {

typename std::set<PermissionDataType>::const_iterator i;

for (i = data_set_.begin(); i != data_set_.end(); ++i) {

std::unique_ptr<base::Value> item_value(i->ToValue());

- list->Append(item_value.release());

+ list->Append(std::move(item_value));

}

return std::unique_ptr<base::Value>(list);

}