chrome/browser/ui/webui/cookies_tree_model_util.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/cookies_tree_model_util.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/browsing_history_handler.cc ('k') | chrome/browser/ui/webui/copresence_ui_handler.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/cookies_tree_model_util.cc

diff --git a/chrome/browser/ui/webui/cookies_tree_model_util.cc b/chrome/browser/ui/webui/cookies_tree_model_util.cc

index 5a81bd5952e6dcd85a195efa47d03aeec06cb28a..d5311963735db722aaf403ba706f2a002def79fa 100644

--- a/chrome/browser/ui/webui/cookies_tree_model_util.cc

+++ b/chrome/browser/ui/webui/cookies_tree_model_util.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/ui/webui/cookies_tree_model_util.h"

#include <memory>

+#include <utility>

#include <vector>

#include "base/i18n/time_formatting.h"

@@ -328,7 +329,7 @@ void CookiesTreeModelUtil::GetChildNodeList(const CookieTreeNode* parent,

std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue);

const CookieTreeNode* child = parent->GetChild(start + i);

if (GetCookieTreeNodeDictionary(*child, dict.get()))

- nodes->Append(dict.release());

+ nodes->Append(std::move(dict));

}