chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc ('k') | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc

diff --git a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc b/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc

index 07a44d829e3e89e42b3d3f3cd4db7dc99ab678f3..42909a29d6785c975d53ecd27c7444ba28955531 100644

--- a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc

+++ b/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc

@@ -278,7 +278,7 @@ void TabCaptureRegistry::GetCapturedTabs(

continue;

tab_capture::CaptureInfo info;

request->GetCaptureInfo(&info);

- list_of_capture_info->Append(info.ToValue().release());

+ list_of_capture_info->Append(info.ToValue());

}

@@ -425,7 +425,7 @@ void TabCaptureRegistry::DispatchStatusChangeEvent(

std::unique_ptr<base::ListValue> args(new base::ListValue());

tab_capture::CaptureInfo info;

request->GetCaptureInfo(&info);

- args->Append(info.ToValue().release());

+ args->Append(info.ToValue());

std::unique_ptr<Event> event(

new Event(events::TAB_CAPTURE_ON_STATUS_CHANGED,

tab_capture::OnStatusChanged::kEventName, std::move(args)));