Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4806)

Unified Diff: chrome/browser/ui/webui/extensions/extension_loader_handler.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_loader_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_loader_handler.cc b/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
index b964b20b9210ef7f7341437091acf933e8c95a7e..7d86b4b09349d4d83fb6356faf40c22a73908a74 100644
--- a/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/ui/webui/extensions/extension_loader_handler.h"
+#include <utility>
+
#include "base/bind.h"
#include "base/files/file_util.h"
#include "base/logging.h"
@@ -198,7 +200,7 @@ void ExtensionLoaderHandler::AddFailure(
new base::StringValue(prettified_path.LossyDisplayName()));
failure->Set("error", new base::StringValue(base::UTF8ToUTF16(error)));
failure->Set("manifest", manifest_value.release());
- failures_.Append(failure.release());
+ failures_.Append(std::move(failure));
// Only notify the frontend if the frontend UI is ready.
if (ui_ready_)

Powered by Google App Engine
This is Rietveld 408576698