Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: extensions/browser/api/web_request/web_request_api.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/web_request_api.cc
diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc
index 9610ca3efdf8984489e279205ea04ebc43fcad21..0d319f2e8f73693beb660ec20a39389e38cb7519 100644
--- a/extensions/browser/api/web_request/web_request_api.cc
+++ b/extensions/browser/api/web_request/web_request_api.cc
@@ -1544,7 +1544,7 @@ base::ListValue* SummarizeCookieModifications(
*mod.modification->name);
}
}
- cookie_modifications->Append(summary.release());
+ cookie_modifications->Append(std::move(summary));
}
return cookie_modifications.release();
}

Powered by Google App Engine
This is Rietveld 408576698