base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

chrome/browser/ui/webui/foreign_session_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/foreign_session_handler.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/i18n/time_formatting.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/values.h"
@@ skipping 83 matching lines @@
   if (window.tabs.empty())
     return nullptr;
   std::unique_ptr<base::ListValue> tab_values(new base::ListValue());
   // Calculate the last |modification_time| for all entries within a window.
   base::Time modification_time = window.timestamp;
   for (const ::sessions::SessionTab* tab : window.tabs) {
     std::unique_ptr<base::DictionaryValue> tab_value(SessionTabToValue(*tab));
     if (tab_value.get()) {
       modification_time = std::max(modification_time,
                                    tab->timestamp);
-      tab_values->Append(tab_value.release());
+      tab_values->Append(std::move(tab_value));
     }
   }
   if (tab_values->GetSize() == 0)
     return nullptr;
   std::unique_ptr<base::DictionaryValue> dictionary(
       BuildWindowData(window.timestamp, window.window_id.id()));
   dictionary->Set("tabs", tab_values.release());
   return dictionary;
 }
 
@@ skipping 173 matching lines @@
 
       std::unique_ptr<base::ListValue> window_list(new base::ListValue());
       const std::string group_name =
           base::FieldTrialList::FindFullName("TabSyncByRecency");
       if (group_name != "Enabled") {
         // Order tabs by visual order within window.
         for (auto map_iter : session->windows) {
           std::unique_ptr<base::DictionaryValue> window_data(
               SessionWindowToValue(*map_iter.second));
           if (window_data.get())
-            window_list->Append(window_data.release());
+            window_list->Append(std::move(window_data));
         }
       } else {
         // Order tabs by recency. This involves creating a synthetic singleton
         // window that contains all the tabs of the session.
         base::Time modification_time;
         std::vector<const ::sessions::SessionTab*> tabs;
         open_tabs->GetForeignSessionTabs(session_tag, &tabs);
         std::unique_ptr<base::ListValue> tab_values(new base::ListValue());
         for (const ::sessions::SessionTab* tab : tabs) {
           std::unique_ptr<base::DictionaryValue> tab_value(
               SessionTabToValue(*tab));
           if (tab_value.get()) {
             modification_time = std::max(modification_time, tab->timestamp);
-            tab_values->Append(tab_value.release());
+            tab_values->Append(std::move(tab_value));
           }
         }
         if (tab_values->GetSize() != 0) {
           std::unique_ptr<base::DictionaryValue> window_data(
               BuildWindowData(modification_time, 1));
           window_data->Set("tabs", tab_values.release());
-          window_list->Append(window_data.release());
+          window_list->Append(std::move(window_data));
         }
       }
 
       session_data->Set("windows", window_list.release());
-      session_list.Append(session_data.release());
+      session_list.Append(std::move(session_data));
     }
   }
   base::FundamentalValue tab_sync_enabled(IsTabSyncEnabled());
   web_ui()->CallJavascriptFunctionUnsafe("setForeignSessions", session_list,
                                          tab_sync_enabled);
 }
 
 void ForeignSessionHandler::HandleOpenForeignSession(
     const base::ListValue* args) {
   size_t num_args = args->GetSize();
@@ skipping 85 matching lines @@
   // collapsed state persists.
   PrefService* prefs = Profile::FromWebUI(web_ui())->GetPrefs();
   DictionaryPrefUpdate update(prefs, prefs::kNtpCollapsedForeignSessions);
   if (is_collapsed)
     update.Get()->SetBoolean(session_tag, true);
   else
     update.Get()->Remove(session_tag, NULL);
 }
 
 }  // namespace browser_sync