chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

diff --git a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

index e941c253ad12e6a692a3f36424b0e241bc667afe..ebf4250039f2c73081c60d7e52bd05a737987db5 100644

--- a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

+++ b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

@@ -83,8 +83,8 @@ void ExperienceSamplingEvent::CreateUserDecisionEvent(

decision.time = base::Time::Now().ToJsTime();

std::unique_ptr<base::ListValue> args(new base::ListValue());

- args->Append(ui_element_.ToValue().release());

- args->Append(decision.ToValue().release());

+ args->Append(ui_element_.ToValue());

+ args->Append(decision.ToValue());

std::unique_ptr<Event> event(

new Event(events::EXPERIENCE_SAMPLING_PRIVATE_ON_DECISION,

api::experience_sampling_private::OnDecision::kEventName,

@@ -100,7 +100,7 @@ void ExperienceSamplingEvent::CreateOnDisplayedEvent() {

if (browser_context_ && browser_context_->IsOffTheRecord())

return;

std::unique_ptr<base::ListValue> args(new base::ListValue());

- args->Append(ui_element_.ToValue().release());

+ args->Append(ui_element_.ToValue());

std::unique_ptr<Event> event(

new Event(events::EXPERIENCE_SAMPLING_PRIVATE_ON_DISPLAYED,

api::experience_sampling_private::OnDisplayed::kEventName,