chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc ('k') | chrome/test/chromedriver/chrome/log.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc

diff --git a/chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc b/chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc

index e45a1f0121db86f138a2e7f3664c501695e5db35..606218ab78b00c51e1daa905c27ef9b30687925c 100644

--- a/chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc

+++ b/chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc

@@ -107,10 +107,8 @@ TEST_F(ChromePermissionMessageProviderUnittest,

std::unique_ptr<UsbDevicePermission> usb(new UsbDevicePermission(

PermissionsInfo::GetInstance()->GetByID(APIPermission::kUsbDevice)));

std::unique_ptr<base::ListValue> devices_list(new base::ListValue());

- devices_list->Append(

- UsbDevicePermissionData(0x02ad, 0x138c, -1).ToValue().release());

- devices_list->Append(

- UsbDevicePermissionData(0x02ad, 0x138d, -1).ToValue().release());

+ devices_list->Append(UsbDevicePermissionData(0x02ad, 0x138c, -1).ToValue());

+ devices_list->Append(UsbDevicePermissionData(0x02ad, 0x138d, -1).ToValue());

ASSERT_TRUE(usb->FromValue(devices_list.get(), nullptr, nullptr));

permissions.insert(usb.release());