chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/media_galleries/media_galleries_api.cc ('k') | chrome/browser/extensions/api/settings_private/settings_private_delegate.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

diff --git a/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc b/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

index 0a35340e620a29b7cde5e4b618e2666e3d625c21..36e86c67aded57e04653a985452ed45b92dd9291 100644

--- a/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

+++ b/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

@@ -139,7 +139,7 @@ void ChromeDirectSettingAPI::OnPrefChanged(

std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);

result->Set(preference_api_constants::kValue, value->DeepCopy());

base::ListValue args;

- args.Append(result.release());

+ args.Append(std::move(result));

for (const scoped_refptr<const extensions::Extension>& extension :

ExtensionRegistry::Get(profile_)->enabled_extensions()) {