Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc
diff --git a/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc b/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc
index b880b8fbe17b1cbffe640de47c5ff8a4d0c1757a..8e6245c283524bc45e5d90893199deef6e00e3ff 100644
--- a/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc
+++ b/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc
@@ -239,7 +239,7 @@ TEST_F(ManagedBookmarksTrackerTest, SwapNodes) {
std::unique_ptr<base::ListValue> updated(CreateTestTree());
std::unique_ptr<base::Value> removed;
ASSERT_TRUE(updated->Remove(0, &removed));
- updated->Append(removed.release());
+ updated->Append(std::move(removed));
// These two nodes should just be swapped.
const BookmarkNode* parent = managed_node();

Powered by Google App Engine
This is Rietveld 408576698