chrome/browser/ui/webui/invalidations_message_handler.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/invalidations_message_handler.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/foreign_session_handler.cc ('k') | chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/invalidations_message_handler.cc

diff --git a/chrome/browser/ui/webui/invalidations_message_handler.cc b/chrome/browser/ui/webui/invalidations_message_handler.cc

index 42e15e8724b0e38bcb1b713846f936e7c465d77e..e39453502d7fb569ad5baf6cb3082dd3c6796777 100644

--- a/chrome/browser/ui/webui/invalidations_message_handler.cc

+++ b/chrome/browser/ui/webui/invalidations_message_handler.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/ui/webui/invalidations_message_handler.h"

+#include <utility>

#include "base/bind.h"

#include "chrome/browser/invalidation/profile_invalidation_provider_factory.h"

#include "chrome/browser/profiles/profile.h"

@@ -102,7 +104,7 @@ void InvalidationsMessageHandler::OnUpdateIds(

dic->SetString("name", (it->first).name());

dic->SetInteger("source", (it->first).source());

dic->SetInteger("totalCount", it->second);

- list_of_objects.Append(dic.release());

+ list_of_objects.Append(std::move(dic));

}

web_ui()->CallJavascriptFunctionUnsafe("chrome.invalidations.updateIds",

base::StringValue(handler_name),