chrome/browser/supervised_user/supervised_user_bookmarks_handler.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/supervised_user/supervised_user_bookmarks_handler.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/spellchecker/feedback_sender.cc ('k') | chrome/browser/sync_file_system/drive_backend/metadata_database.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/supervised_user/supervised_user_bookmarks_handler.h"	5 #include "chrome/browser/supervised_user/supervised_user_bookmarks_handler.h"

6	6

7 #include <stddef.h>	7 #include <stddef.h>

8 #include <utility>	8 #include <utility>

9	9

10 #include "base/logging.h"	10 #include "base/logging.h"

(...skipping 194 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
205 }	205 }

206 }	206 }

207 }	207 }

208	208

209 bool SupervisedUserBookmarksHandler::AddNodeToTree(	209 bool SupervisedUserBookmarksHandler::AddNodeToTree(

210 int parent_id,	210 int parent_id,

211 std::unique_ptr<base::DictionaryValue> node) {	211 std::unique_ptr<base::DictionaryValue> node) {

212 base::ListValue* parent = FindFolder(root_.get(), parent_id);	212 base::ListValue* parent = FindFolder(root_.get(), parent_id);

213 if (!parent)	213 if (!parent)

214 return false;	214 return false;

215 parent->Append(node.release());	215 parent->Append(std::move(node));

216 return true;	216 return true;

217 }	217 }

OLD	NEW