base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h"
 
 #include <stddef.h>
 
 #include <memory>
+#include <utility>
 
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/values.h"
 #include "content/public/browser/resource_request_info.h"
 #include "extensions/browser/api/declarative_webrequest/webrequest_condition.h"
 #include "extensions/browser/api/declarative_webrequest/webrequest_constants.h"
 #include "net/base/request_priority.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
@@ skipping 361 matching lines @@
       std::unique_ptr<base::Value> entry_owned;
       base::ListValue* list = NULL;
       if (!dictionary->GetWithoutPathExpansion(*name, &entry))
         return std::unique_ptr<base::DictionaryValue>();
       switch (entry->GetType()) {
         case base::Value::TYPE_STRING:
           // Replace the present string with a list.
           list = new base::ListValue;
           // Ignoring return value, we already verified the entry is there.
           dictionary->RemoveWithoutPathExpansion(*name, &entry_owned);
-          list->Append(entry_owned.release());
+          list->Append(std::move(entry_owned));
           list->AppendString(*value);
           dictionary->SetWithoutPathExpansion(*name, list);
           break;
         case base::Value::TYPE_LIST:  // Just append to the list.
           CHECK(entry->GetAsList(&list));
           list->AppendString(*value);
           break;
         default:
           NOTREACHED();  // We never put other Values here.
           return std::unique_ptr<base::DictionaryValue>();
@@ skipping 13 matching lines @@
 void MatchAndCheck(const std::vector< std::vector<const std::string*> >& tests,
                    const std::string& key,
                    RequestStage stage,
                    net::URLRequest* url_request,
                    bool* result) {
   base::ListValue contains_headers;
   for (size_t i = 0; i < tests.size(); ++i) {
     std::unique_ptr<base::DictionaryValue> temp(
         GetDictionaryFromArray(tests[i]));
     ASSERT_TRUE(temp.get());
-    contains_headers.Append(temp.release());
+    contains_headers.Append(std::move(temp));
   }
 
   std::string error;
   scoped_refptr<const WebRequestConditionAttribute> attribute =
       WebRequestConditionAttribute::Create(key, &contains_headers, &error);
   ASSERT_EQ("", error);
   ASSERT_TRUE(attribute.get());
   EXPECT_EQ(key, attribute->GetName());
 
   *result = attribute->IsFulfilled(WebRequestData(
@@ skipping 276 matching lines @@
   };
   const size_t kExistingSize[] = { arraysize(kExisting) };
   GetArrayAsVector(kExisting, kExistingSize, 1u, &tests);
   MatchAndCheck(tests, keys::kExcludeResponseHeadersKey, stage,
                 url_request.get(), &result);
   EXPECT_FALSE(result);
 }
 
 }  // namespace
 }  // namespace extensions