extensions/browser/api/declarative/rules_registry.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/rules_registry.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/bluetooth/bluetooth_api.cc ('k') | extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative/rules_registry.cc

diff --git a/extensions/browser/api/declarative/rules_registry.cc b/extensions/browser/api/declarative/rules_registry.cc

index fd77d4646ff67579f69a5158e7e89465fef7c725..718a8ef2c5fb9d325afa66bf0f8e45dee114a64b 100644

--- a/extensions/browser/api/declarative/rules_registry.cc

+++ b/extensions/browser/api/declarative/rules_registry.cc

@@ -42,7 +42,7 @@ std::unique_ptr<base::Value> RulesToValue(

const std::vector<linked_ptr<api::events::Rule>>& rules) {

std::unique_ptr<base::ListValue> list(new base::ListValue());

for (size_t i = 0; i < rules.size(); ++i)

- list->Append(rules[i]->ToValue().release());

+ list->Append(rules[i]->ToValue());

return std::move(list);

Nico 2016/06/09 16:57:35 huh, why doesn't clang issue a -Wpessimizing-move

dcheng 2016/06/09 17:09:46 C++11 still requires an explicit std::move() here,

}