components/policy/core/browser/configuration_policy_handler.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/configuration_policy_handler.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/invalidation/public/single_object_invalidation_set.cc ('k') | components/proximity_auth/webui/proximity_auth_webui_handler.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/browser/configuration_policy_handler.cc

diff --git a/components/policy/core/browser/configuration_policy_handler.cc b/components/policy/core/browser/configuration_policy_handler.cc

index e90767a36722955f7e6748853c0a3d98f107df85..c7b3afa5b599f7b5424868fbe54ecfe153463699 100644

--- a/components/policy/core/browser/configuration_policy_handler.cc

+++ b/components/policy/core/browser/configuration_policy_handler.cc

@@ -216,7 +216,7 @@ bool StringMappingListPolicyHandler::Convert(const base::Value* input,

std::unique_ptr<base::Value> mapped_value = Map(entry_value);

if (mapped_value) {

if (output)

- output->Append(mapped_value.release());

+ output->Append(std::move(mapped_value));

} else {

if (errors) {

errors->AddError(policy_name(),