chrome/browser/ui/webui/options/password_manager_handler.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/password_manager_handler.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/core_options_handler.cc ('k') | chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/password_manager_handler.cc

diff --git a/chrome/browser/ui/webui/options/password_manager_handler.cc b/chrome/browser/ui/webui/options/password_manager_handler.cc

index c15af4656c18f012437ea3145e1b865ca63c70a0..6a5545690eaee7dfdfffb44f8af7ca251e6d8975 100644

--- a/chrome/browser/ui/webui/options/password_manager_handler.cc

+++ b/chrome/browser/ui/webui/options/password_manager_handler.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/ui/webui/options/password_manager_handler.h"

+#include <utility>

#include "base/bind.h"

#include "base/command_line.h"

#include "base/feature_list.h"

@@ -283,7 +285,7 @@ void PasswordManagerHandler::SetPasswordList(

base::UTF8ToUTF16(saved_password->federation_origin.host())));

}

- entries.Append(entry.release());

+ entries.Append(std::move(entry));

}

web_ui()->CallJavascriptFunctionUnsafe(

@@ -297,7 +299,7 @@ void PasswordManagerHandler::SetPasswordExceptionList(

for (const auto& exception : password_exception_list) {

std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue);

CopyOriginInfoOfPasswordForm(*exception, entry.get());

- entries.Append(entry.release());

+ entries.Append(std::move(entry));

}

web_ui()->CallJavascriptFunctionUnsafe(