content/renderer/devtools/v8_sampling_profiler_browsertest.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/v8_sampling_profiler_browsertest.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_context_impl.cc ('k') | extensions/browser/api/alarms/alarm_manager.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/devtools/v8_sampling_profiler_browsertest.cc

diff --git a/content/renderer/devtools/v8_sampling_profiler_browsertest.cc b/content/renderer/devtools/v8_sampling_profiler_browsertest.cc

index ac750b463e4515f0a3ce064bb3d94cb12e62a0cf..eb1f2af080f4b522152b5f48348ef186b433e68c 100644

--- a/content/renderer/devtools/v8_sampling_profiler_browsertest.cc

+++ b/content/renderer/devtools/v8_sampling_profiler_browsertest.cc

@@ -2,15 +2,18 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "content/renderer/devtools/v8_sampling_profiler.h"

#include <stddef.h>

+#include <utility>

#include "base/json/json_reader.h"

#include "base/memory/ref_counted_memory.h"

#include "base/run_loop.h"

#include "base/trace_event/trace_buffer.h"

#include "base/trace_event/trace_event.h"

#include "content/public/test/render_view_test.h"

-#include "content/renderer/devtools/v8_sampling_profiler.h"

using base::DictionaryValue;

using base::ListValue;

@@ -75,7 +78,7 @@ class V8SamplingProfilerTest : public RenderViewTest {

while (root_list->GetSize()) {

std::unique_ptr<Value> item;

root_list->Remove(0, &item);

- trace_parsed_.Append(item.release());

+ trace_parsed_.Append(std::move(item));

}

if (!has_more_events)