Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: components/proximity_auth/webui/proximity_auth_webui_handler.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/proximity_auth/webui/proximity_auth_webui_handler.cc
diff --git a/components/proximity_auth/webui/proximity_auth_webui_handler.cc b/components/proximity_auth/webui/proximity_auth_webui_handler.cc
index 3677b310d311c8efd144973157b7399e279da298..41d391f71f2f423215e5709bf72ad79a9a22a5ac 100644
--- a/components/proximity_auth/webui/proximity_auth_webui_handler.cc
+++ b/components/proximity_auth/webui/proximity_auth_webui_handler.cc
@@ -237,7 +237,7 @@ void ProximityAuthWebUIHandler::OnWebContentsInitialized(
void ProximityAuthWebUIHandler::GetLogMessages(const base::ListValue* args) {
base::ListValue json_logs;
for (const auto& log : *LogBuffer::GetInstance()->logs()) {
- json_logs.Append(LogMessageToDictionary(log).release());
+ json_logs.Append(LogMessageToDictionary(log));
}
web_ui()->CallJavascriptFunctionUnsafe("LogBufferInterface.onGotLogMessages",
json_logs);

Powered by Google App Engine
This is Rietveld 408576698