extensions/browser/api/hid/hid_device_manager.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/hid/hid_device_manager.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/declarative/rules_registry.cc ('K') | « extensions/browser/api/device_permissions_manager.cc ('k') | extensions/browser/api/networking_private/networking_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/hid/hid_device_manager.cc

diff --git a/extensions/browser/api/hid/hid_device_manager.cc b/extensions/browser/api/hid/hid_device_manager.cc

index ba92267529e857fa10bef4c86280ada833673d01..3985c4fe3aee86e5928f4febcbe669a3145d0015 100644

--- a/extensions/browser/api/hid/hid_device_manager.cc

+++ b/extensions/browser/api/hid/hid_device_manager.cc

@@ -146,7 +146,7 @@ std::unique_ptr<base::ListValue> HidDeviceManager::GetApiDevicesFromList(

hid::HidDeviceInfo device_info;

device_info.device_id = device_entry->second;

PopulateHidDeviceInfo(&device_info, device);

- device_list->Append(device_info.ToValue().release());

+ device_list->Append(device_info.ToValue());

}

return device_list;

}